Skip to main content

re: Javascript issue on SiteGround - confirmed it with them

Bryan M
  • Edited

 

 

the latest update to Brizy seems to have issue with SiteGround and their "Optimizer" plugin. No problems with previous version, now my testimonial blocks do NOT show up if I turn on Minify Javascipt (to speed things up). This is what the SiteGround tech said below:

"Thank you for the patience, the issue is caused by the first JS error we see actually. It seems that brizy have not closed a function in their JS code, but our plugin appears to be triggering it. In this case I will post a ticket indeed so our advanced technical team can escalate this to our devs possibly and they could maybe adjust it either now or in the next release of our plugin."

As I said, it's a new issue, the site worked fine a couple weeks ago, I updated to Brizy 2.4.17 and Pro 2.4.16 and now the testimonials are gone with an error in the console (when minify is enabled).

Attached 2 screen shots

 

*** UPDATE***

Just in from SiteGround techs, see below, is this something that needs to be fixed in the next Brizy update?

"I reviewed your case and I was able to re-create the reported issue. I then checked what script handles is the main page of the site loading and I found that the script which is causing the issues is using handle brizy-asset-main-30."

After this using the following script in the functions.php file of the theme:

add_filter( 'sgo_js_minify_exclude', 'js_minify_exclude' );

function js_minify_exclude( $exclude_list ) {

    $exclude_list[] = 'brizy-asset-main-30';



    return $exclude_list;

}

"I excluded the brizy-asset-main-30 from the JavaScript Minify of the SG Optimizer. Now the Minify JavaScript Files option is enabled and the testimonials are working properly"

 

 

0

Comments

19 comments

Date Votes
  • KC George

    Hi Bryan,

    Thanks for reporting this issue. We are aware of it and have escalated it to our developers and we will work rolling out a fix for this in one of our future updates.

    0
  • Bryan M

    Ok great! I'm glad you will be fixing this.

    0
  • KC George

    Thanks Bryan for the comment from the SG Optimizer team. I have passed it on to our developers.

    0
  • Ben Scott

    please let me know when this is fixed 

    if anyone has an idea of how to manually enter 

    wp-content/uploads/siteground-optimizer-assets/brizy-asset-main-30.min.js

    into the javascript minification of site ground optimiser I would appreciate as it appears to only pick up a few files for exclusion using a dropdown and doesn't allow for text entry

     

    thanks Ben

    0
  • KC George
    • Edited

    Hi Ben,

    You are right; by default, you do not see the option brizy-asset-main-30 in the "Exclude from JavaScript Minification" dropdown. As I understand the feedback from the SiteGround team in the original post, adding the lines of code mentioned above to the theme's functions.php excludes the brizy-asset-main-30.min.js from the SG Optimizer's Javascript Minifications.

    Disclaimer: I have not tested this myself and hence cannot confirm from personal experience

    0
  • Ben Scott

    thanks for the reply, I have reached out to siteground and will see what I can do from there

     

    0
  • Ben Scott

    https://wordpress.org/support/topic/how-to-use-sg-optimizers-filters-procedure/

    this was sent to me as explanation of what can be done

    0
  • Ben Scott

    I can confirm no need to modify the function.php just use snippets plugin and works fine

    0
  • KC George

    Thanks Ben for the update

    0
  • Ben Scott

    issue seems to be happening again, probably needs different code. its a bit of a pain

     

    0
  • Ben Scott

    appears to be an issue with javascript files being combined, which files would be good to exclude which are brizy specific?

    0
  • Ariel H.

    Hi Ben,

    Thank you for reaching out to us.

    Could you please provide us your website URL so we can inspect it?

    Best regards,
    Ariel H.

    0
  • Ben Scott

    https://staging6.colemanprojects.org.uk/brizy/ I was also having same issue on salus.mobi but for this site I have temporarily disabled the siteground optimiser plugin

    I can get the https://staging6.colemanprojects.org.uk/brizy/ to work with the combine javascript files turned off. I used to have issues with the minimise files but that I think maybe fixed through use of a snippet in placeo of functions.php rules

    why is the plugin not presenting itself to become an exception, is that not something which could be flagged for these optimisations plugins?

    0
  • Ariel H.

    Hi Ben,

    Thank you for the update.

    Lately, we've been facing some compatibility problems with SiteGround Optimizer. Unfortunately, this is an ongoing issue. We recommend temporarily disabling these optimization options until we find a solution. Apologies for the inconvenience.

    Best regards,
    Ariel H.

    0
  • Ben Scott

    when do you think you might have a solution? thanks

    0
  • Ariel H.

    Hi Ben,

    Regrettably, we can't specify a precise date at the moment, but rest assured, we will get in touch with you as soon as we have more information.

    Best regards,
    Ariel H.

    0
  • Ben Scott

    I am in contact with siteground and will pass over any information which may help

     

    0
  • Ben Scott

    https://eu.siteground.com/tutorials/wordpress/speed-optimizer/custom-filters/ 

    this has code for all instances, presume it would only be 

    brizy-asset-main-30
    0
  • Ariel H.

    Hi Ben,

    Thank you for the update.

    We are aware of this asset (brizy-asset-main-30) currently we're finding a better approach to resolve the issue.

    Best regards,
    Ariel H.

    0

Please sign in to leave a comment.

Didn't find what you were looking for?

Ask a Question